[FLINK-19248] add missing lastJobExecutionResult assignment after job finished in ContexEnvironment

[jsycdut]

What is the purpose of the change

This pull request fixes issue FLINK-19248 opened by myself.

Brief change log

• assign the jobExecutionResult to lastJobExecutionResult after job finished in ContextEnvironment

Verifying this change

This change is a trivial rework / code cleanup without any test coverage. I add only one line of code in ContextEnvironment to fix the issue, it can be verified as issue FLINK-19248 says.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3eedbea (Fri Feb 19 07:20:30 UTC 2021)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 3eedbea Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[aljoscha]

Thanks for the fix! I had a comment inline but I think it would also be good to add a test for this. The test should basically create a ContextEnvironment, run a job, and then call getLastResult().

[aljoscha]

Instead of using a local variable jobExecutionResult we could just always use the field lastJobExecutionResult here.

[jsycdut]

I got you.

[hailuand]

Hi @aljoscha, @jsycdut,

We ran into this problem today, and bringing over this patch locally solved our issue 🤓 Is there any plans to move this forward?

[hailuand]

Hi @aljoscha I can help with this here if all that’s missing is a test! Do you know where I can find examples of creating a ContextEnvironment? I was having trouble finding one myself.