[FLINK-19227][Table SQL / API] The catalog is still created after opening failed in catalog registering

[zhuxiaoshang]

What is the purpose of the change

When I create the HiveCatalog and Flink is not able to connect to the HiveMetastore, the statement can not be executed, but the catalog is still created. Subsequent attempts to query the tables result in a NPE.

In CatalogManager.registerCatalog.
Consider open is a relatively easy operation to fail, we should put catalog into catalog manager after its open.

Brief change log

• have a double check about hive metastore client is whether created successfully and fail fast if not.
• put catalog into catalog manager when the catalog is opened successfully.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? ( no)
• If yes, how is the feature documented? (not documented)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit b392f6a (Fri Feb 19 07:23:00 UTC 2021)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[JingsongLi]

Thanks for the contribution, left some comments.

[JingsongLi]

This should not happen.

[zhuxiaoshang]

ok,i got it and i'll remove it

[JingsongLi]

Can you add a case for this?
You can create a Catalog extends GenericInMemoryCatalog and implement open to throw exception. The check the TableEnv should not contains this catalog.

[zhuxiaoshang]

thanks for your suggestions.i'll add a test case.

[flinkbot]

CI report:

• b392f6a Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[zhuxiaoshang]

@flinkbot run azure

[zhuxiaoshang]

@flinkbot run azure

[JingsongLi]

Thanks @zhuxiaoshang for the update, looks good to me! Merging...