[FLINK-19403][python] Support Pandas Stream Group Window Aggregation #13483

HuangXingBo · 2020-09-25T12:22:27Z

What is the purpose of the change

This pull request will support Pandas Stream Group Window Aggregation

Brief change log

Add StreamArrowPythonGroupWindowAggregateFunctionOperator
Add Physical Rule and RelNode

Verifying this change

This change added tests and can be verified as follows:

Add UT PythonGroupWindowAggregateTest
Add IT StreamPandasUDAFITTests

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

flinkbot · 2020-09-25T12:25:24Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit cceb5e9 (Fri Feb 19 07:28:25 UTC 2021)

Warnings:

No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot · 2020-09-25T12:38:14Z

CI report:

58c1c65 Azure: CANCELED
cceb5e9 Azure: PENDING

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run travis re-run the last Travis build
@flinkbot run azure re-run the last Azure build

dianfu · 2020-09-27T01:42:41Z

flink-python/pyflink/table/tests/test_pandas_udaf.py

@@ -259,6 +261,128 @@ def test_over_window_aggregate_function(self):
                            "3,2.0,3,2.0,1.0,1.0,2.0,2.0,1.0,1.0"])


+class StreamPandasUDAFITTests(PyFlinkBlinkStreamTableTestCase):
+    def test_group_window_aggregate_function_over_time(self):


Suggested change

def test_group_window_aggregate_function_over_time(self):

def test_sliding_group_window_over_time(self):

dianfu · 2020-09-27T01:43:08Z

flink-python/pyflink/table/tests/test_pandas_udaf.py

+                            "3,2018-03-11 02:30:00.0,2018-03-11 03:30:00.0,2.0"])
+        os.remove(source_path)
+
+    def test_group_window_aggregate_function_over_count(self):


Suggested change

def test_group_window_aggregate_function_over_count(self):

def test_sliding_group_window_over_count(self):

dianfu · 2020-09-27T01:46:50Z

...ors/python/aggregate/arrow/stream/StreamArrowPythonGroupWindowAggregateFunctionOperator.java

+	/**
+	 * For serializing the window in checkpoints.
+	 */
+	private TypeSerializer<W> windowSerializer;


Suggested change

private TypeSerializer<W> windowSerializer;

private transient TypeSerializer<W> windowSerializer;

dianfu · 2020-09-27T02:04:15Z

...ors/python/aggregate/arrow/stream/StreamArrowPythonGroupWindowAggregateFunctionOperator.java

+	private void emitWindowResult(W window) throws Exception {
+		windowAccumulateData.setCurrentNamespace(window);
+		windowRetractData.setCurrentNamespace(window);
+		Iterable<RowData> currentWindowAccumulateDatas = windowAccumulateData.get();


Suggested change

Iterable<RowData> currentWindowAccumulateDatas = windowAccumulateData.get();

Iterable<RowData> currentWindowAccumulateData = windowAccumulateData.get();

dianfu · 2020-09-27T02:07:19Z

...ors/python/aggregate/arrow/stream/StreamArrowPythonGroupWindowAggregateFunctionOperator.java

+		if (currentWindowAccumulateDatas != null) {
+			currentBatchCount = 0;
+			for (RowData accumulateData : currentWindowAccumulateDatas) {
+				if (!hasRetractData(accumulateData)) {


So for each input data, we have to iterate the retract state. I guess the performance should be very poor. Could we improve this?

dianfu · 2020-09-27T02:17:05Z

...ors/python/aggregate/arrow/stream/StreamArrowPythonGroupWindowAggregateFunctionOperator.java

+		}
+	}
+
+	private void emitWindowResult(W window) throws Exception {


The method names emitWindowResult and emitResult are similar, however, the functionalities are very different.

What about rename emitWindowResult to something else, such as processWindow or triggerWindow.

dianfu · 2020-09-27T02:23:11Z

...ors/python/aggregate/arrow/stream/StreamArrowPythonGroupWindowAggregateFunctionOperator.java

+		for (int i = 0; i < namedProperties.length; i++) {
+			switch (namedProperties[i]) {
+				case 0:
+					windowProperty.setField(i, TimestampData.fromEpochMillis(((TimeWindow) currentWindow).getStart()));


Why it's always TimeWindow?

Because CountWindow won't set the start property or the end property, we can make sure it is a TimeWindow.

dianfu · 2020-09-27T02:36:42Z

...ors/python/aggregate/arrow/stream/StreamArrowPythonGroupWindowAggregateFunctionOperator.java

+		}
+
+		@Override
+		public void clearWindowState(W window) {


When will this method be called?

dianfu · 2020-09-27T02:36:58Z

...ors/python/aggregate/arrow/stream/StreamArrowPythonGroupWindowAggregateFunctionOperator.java

+		}
+
+		@Override
+		public void clearTrigger(W window) throws Exception {


dianfu · 2020-09-27T02:51:00Z

flink-python/pyflink/table/tests/test_pandas_udaf.py

+        self.assert_equals(actual, ["1,2.5", "1,5.5", "2,2.0", "3,2.5"])
+        os.remove(source_path)
+
+


Should we also add test case for Tumble window?

HuangXingBo · 2020-09-27T06:17:44Z

@dianfu Thanks a lot for the review. I have addressed the comments at the latest commit.

dianfu

@HuangXingBo Thanks for the update. Just two minor comments.

dianfu · 2020-09-27T06:58:54Z

...ors/python/aggregate/arrow/stream/StreamArrowPythonGroupWindowAggregateFunctionOperator.java

+			internalTimerService.deleteEventTimeTimer(window, time);
+		}
+
+		public void clear() throws Exception {


Suggested change

public void clear() throws Exception {

@Override

public void clear() throws Exception {

dianfu · 2020-09-27T07:04:29Z

flink-python/pyflink/table/tests/test_pandas_udaf.py

@@ -259,6 +261,246 @@ def test_over_window_aggregate_function(self):
                            "3,2.0,3,2.0,1.0,1.0,2.0,2.0,1.0,1.0"])


+class StreamPandasUDAFITTests(PyFlinkBlinkStreamTableTestCase):
+    def test_sliding_group_window_over_time(self):


could you improve the test cases containing multiple keys?

HuangXingBo · 2020-09-27T07:24:48Z

@dianfu Thanks a lot for the review. I have addressed the comments at the latest commit.

dianfu

LGTM

rmetzger added the review=description? label Sep 25, 2020

rmetzger added the component=API/Python label Sep 25, 2020

dianfu self-assigned this Sep 27, 2020

[FLINK-19403][python] Support Pandas Stream Group Window Aggregation

8516cca

HuangXingBo force-pushed the FLINK-19403 branch from c89615b to 8516cca Compare September 27, 2020 02:38

dianfu reviewed Sep 27, 2020

View reviewed changes

address comments

58c1c65

dianfu reviewed Sep 27, 2020

View reviewed changes

address comments-2

cceb5e9

dianfu approved these changes Sep 27, 2020

View reviewed changes

dianfu closed this in 0bd4e46 Sep 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-19403][python] Support Pandas Stream Group Window Aggregation #13483

[FLINK-19403][python] Support Pandas Stream Group Window Aggregation #13483

HuangXingBo commented Sep 25, 2020

flinkbot commented Sep 25, 2020 •

edited

flinkbot commented Sep 25, 2020 •

edited

dianfu Sep 27, 2020

dianfu Sep 27, 2020

dianfu Sep 27, 2020

dianfu Sep 27, 2020

dianfu Sep 27, 2020

dianfu Sep 27, 2020

dianfu Sep 27, 2020

HuangXingBo Sep 27, 2020

dianfu Sep 27, 2020

dianfu Sep 27, 2020

dianfu Sep 27, 2020

HuangXingBo commented Sep 27, 2020

dianfu left a comment

dianfu Sep 27, 2020

dianfu Sep 27, 2020

HuangXingBo commented Sep 27, 2020

dianfu left a comment

	def test_group_window_aggregate_function_over_time(self):
	def test_sliding_group_window_over_time(self):

	def test_group_window_aggregate_function_over_count(self):
	def test_sliding_group_window_over_count(self):

	private TypeSerializer<W> windowSerializer;
	private transient TypeSerializer<W> windowSerializer;

	Iterable<RowData> currentWindowAccumulateDatas = windowAccumulateData.get();
	Iterable<RowData> currentWindowAccumulateData = windowAccumulateData.get();

		self.assert_equals(actual, ["1,2.5", "1,5.5", "2,2.0", "3,2.5"])
		os.remove(source_path)

	public void clear() throws Exception {
	@Override
	public void clear() throws Exception {

[FLINK-19403][python] Support Pandas Stream Group Window Aggregation #13483

[FLINK-19403][python] Support Pandas Stream Group Window Aggregation #13483

Conversation

HuangXingBo commented Sep 25, 2020

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

flinkbot commented Sep 25, 2020 • edited

Automated Checks

Review Progress

flinkbot commented Sep 25, 2020 • edited

CI report:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HuangXingBo commented Sep 27, 2020

dianfu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HuangXingBo commented Sep 27, 2020

dianfu left a comment

Choose a reason for hiding this comment

flinkbot commented Sep 25, 2020 •

edited

flinkbot commented Sep 25, 2020 •

edited