New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-19409][Documentation] remove unrelated comment for getValue in ListView #13487
[FLINK-19409][Documentation] remove unrelated comment for getValue in ListView #13487
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 9cbc32f (Sun Sep 27 02:31:28 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@wuchong Please review the code. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current example code is still hard to understand. Could you make it to be a more practical example? The example in MapView
is nice, you can take that as an example.
9cbc32f
to
f756ebd
Compare
@wuchong It is a valuable suggestion and I have change the example. Have a code review? |
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/dataview/ListView.java
Outdated
Show resolved
Hide resolved
f756ebd
to
86351d8
Compare
What is the purpose of the change
In class ListView, the comment for method getValue has unrelated code 'accumulator.list.add(id);'. Users and developers may be confused with the comment. It should be removed.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation