Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-19434][DataStream API] Add source input chaining to StreamingJobGraphGenerator #13513

Closed
wants to merge 4 commits into from

Conversation

StephanEwen
Copy link
Contributor

Prerequisites

This PR is based on #13512 , on which it relies as a testing util.

What is the purpose of the change

This adds the StreamingJobGraphGenerator logic for chaining sources to N-Ary-Input Operators.
Joint work with @tsreaper.

Verifying this change

This change adds the SourceChainingITCase to verify correctness.
The fact that the changes do not interfere with other stream graph setup logic is covered by the existing StreamingJobGraphGeneratorTest and the sum of all end-to-end integration tests that execute DataStream and Table programs.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 73ff86c (Tue Sep 29 21:41:53 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 29, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

StephanEwen and others added 4 commits October 2, 2020 13:56
…ity from StreamNode.

The StreamNode implements Serializable, but contains non-serializable structures.
…obGraphGenerator (part 2)

This fixes issues with InputGate numbering and with Operators that have a mix of chained sources
and network inputs.
…obGraphGenerator (part 3)

Some cleanups in StreamingJobGraphGenerator:

  - checking for chainability via ChainingStrategy
  - passing chain entry points as parameters, not as fields
  - fix input gate index for network unions
@StephanEwen
Copy link
Contributor Author

The discussion / review for this PR happened on feature branches between the developers.
We worked directly on a feature, because the branch included some preliminary code to enable this feature for the Blink query engine and use the TPC_DS workload for testing.

@StephanEwen StephanEwen closed this Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants