FLINK-3013: Incorrect package declaration in GellyScalaAPICompletenessTest.scala and gelly code cleanup #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR =) There seems like some extra changes which not related to changing the package declaration which related to code clean up. We prefer to have code cleanup done as separate PR or commit.
Thanks again for the contribution. |
smarthi
changed the title
|
Updated the PR title and description |
|
Thanks a lot for the PR @smarthi! +1 to merge. |
|
Will merge it. |
asfgit
pushed a commit
that referenced
this pull request
Nov 19, 2015
…mpletenessTest.scala This closes #1356.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also includes code cleanup of the Gelly and Gelly-Scala code - remove unnecessary semi-colons in Scala code, unnecessary typeInfo on collection instantiation in java