Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-17528][table] Remove RowData#get() and ArrayData#get() and use FieldGetter and ElementGetter instead #13653

Closed
wants to merge 2 commits into from
Closed

[FLINK-17528][table] Remove RowData#get() and ArrayData#get() and use FieldGetter and ElementGetter instead #13653

wants to merge 2 commits into from

Conversation

wuchong
Copy link
Member

@wuchong wuchong commented Oct 15, 2020

What is the purpose of the change

Currently, we are using utility RowData#get(RowData, int, LogicalType) and ArrayData#get(ArrayData, int, LogicalType) to get the field/element objects. They have been deprecated since 1.11, we should replace them by RowData#FieldGetter and ArrayData#ElementGetter.

Brief change log

  • Use RowData#FieldGetter and ArrayData#ElementGetter to replace RowData#get(..) and ArrayData#get(..)

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@wuchong wuchong changed the title Row data#get [FLINK-17528][table] Remove RowData#get() and ArrayData#get() and use FieldGetter and ElementGetter instead Oct 15, 2020
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 324bdc2 (Thu Oct 15 13:23:13 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • Invalid pull request title: No valid Jira ID provided

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 15, 2020 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@wuchong
Copy link
Member Author

wuchong commented Oct 19, 2020

The failed e2e case is not stable recently.

JingsongLi
JingsongLi reviewed Oct 19, 2020
View reviewed changes
...ble/flink-table-common/src/main/java/org/apache/flink/table/data/binary/BinaryArrayData.java Outdated
@@ -507,7 +507,8 @@ private void checkNoNull() {
T[] values = (T[]) Array.newInstance(elementClass, size);
for (int i = 0; i < size; i++) {
if (!isNullAt(i)) {
values[i] = (T) ArrayData.get(this, i, elementType);
ArrayData.ElementGetter elementGetter = ArrayData.createElementGetter(elementType);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elementGetter should be out of for loop.

...le/flink-table-runtime-blink/src/main/java/org/apache/flink/table/data/util/RowDataUtil.java Outdated
@@ -58,7 +58,8 @@ public static GenericRowData toGenericRow(
if (row.isNullAt(i)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should move this class to test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think so. Will move it.

JingsongLi
JingsongLi approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after azure passing

@wuchong
Copy link
Member Author

wuchong commented Oct 19, 2020

@flinkbot run azure

1 similar comment
@wuchong
Copy link
Member Author

wuchong commented Oct 20, 2020

@flinkbot run azure

@wuchong
Copy link
Member Author

wuchong commented Oct 21, 2020

@flinkbot run azure

1 similar comment
@wuchong
Copy link
Member Author

wuchong commented Oct 21, 2020

@flinkbot run azure

wuchong added a commit to wuchong/flink that referenced this pull request Oct 22, 2020
@wuchong
[FLINK-17528][table] Remove RowData#get() API and use FieldGetter ins…
6c1e8a7 
…tead

This closes apache#13653
wuchong added a commit to wuchong/flink that referenced this pull request Oct 22, 2020
@wuchong
[FLINK-17528][table] Remove ArrayData#get() API and use ElementGetter…
0c876d6 
… instead

This closes apache#13653
@wuchong
Copy link
Member Author

wuchong commented Oct 22, 2020

@flinkbot run azure

1 similar comment
@wuchong
Copy link
Member Author

wuchong commented Oct 22, 2020

@flinkbot run azure

@wuchong
Copy link
Member Author

wuchong commented Oct 22, 2020

Finally passed in my private Azure: https://dev.azure.com/imjark/Flink/_build/results?buildId=301&view=results

Will merge this!

@wuchong wuchong closed this in debbdc6 Oct 22, 2020
wuchong added a commit that referenced this pull request Oct 22, 2020
@wuchong
[FLINK-17528][table] Remove ArrayData#get() API and use ElementGetter…
3b9e20a 
… instead

This closes #13653
@wuchong wuchong deleted the RowData#get branch October 22, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees
No one assigned
Labels
component=TableSQL/API review=description?
Projects
None yet
Milestone
No milestone
4 participants
@wuchong @flinkbot @JingsongLi @rmetzger