New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-19726][table] Implement new providers for blink planner #13696
Conversation
8245c23
to
dad3de0
Compare
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 8245c23 (Tue Oct 20 05:47:31 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, I left a few minor comments
/** | ||
* Checks writing null values into NOT NULL columns. | ||
*/ | ||
public class SinkNotNullEnforcer implements FilterFunction<RowData> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add serialVersionUID
|
||
@Override | ||
public boolean filter(RowData row) { | ||
if (notNullCheck) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: return false
directly when notNullCheck is false, reduce nesting depth.
2131f17
to
b008b76
Compare
b008b76
to
2047202
Compare
What is the purpose of the change
Implement SourceProvider DataStreamScanProvider DataStreamSinkProvider in Blink planner.
Brief change log
CommonPhysicalTableSourceScan
CommonPhysicalSink
Verifying this change
TableSinkITCase
TableSourceITCase
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation