New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-19508][DataStream] Add collect() operation on DataStream #13752
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit f621e5d (Thu Oct 22 20:34:02 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes! I think it would be good to make ClientAndIterator
(Auto)Closeable
to make the code cleaner. I had a nitpick about code duplication.
Also, I can see you paid special attention to the Scala API. You must like that API a lot. 👌
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
Outdated
Show resolved
Hide resolved
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
Outdated
Show resolved
Hide resolved
Thanks for taking a look, I think I've addressed all the commends. @aljoscha you know there's nothing more important to me than a well-loved scala api. |
|
||
@Override | ||
public void close() throws Exception { | ||
iterator.close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ignore this nit, but I think it can happen that close()
throws and then client.cancel()
will not be called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👌
What is the purpose of the change
Promote
DataStreamUtils#collect
to aDataStream#collect
.Verifying this change
UT
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation