[FLINK-19789][hive] Migrate Hive connector to new table source sink interface #13771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 03bad16 (Fri Oct 23 12:23:36 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
JingsongLi
force-pushed
the
hiveNewTableSource
branch
from
03bad16
to
e544295
Compare
JingsongLi
force-pushed
the
hiveNewTableSource
branch
from
e544295
to
7cb29bd
Compare
fsk119
reviewed
Oct 26, 2020
| @@ -239,46 +239,40 @@ public RexNode visitInputRef(RexInputRef inputRef) { | |||
| // get partitions from table/catalog and prune | |||
| Optional<Catalog> catalogOptional = context.getCatalogManager().getCatalog(tableSourceTable.tableIdentifier().getCatalogName()); | |||
| List<Map<String, String>> remainingPartitions; | |||
There was a problem hiding this comment.
Unused field remainingPartitions
danny0405
reviewed
Oct 27, 2020
| public void applyPartitions(List<Map<String, String>> remainingPartitions) { | ||
| if (catalogTable.getPartitionKeys() != null && catalogTable.getPartitionKeys().size() != 0) { | ||
| this.remainingPartitions = remainingPartitions; | ||
| } |
There was a problem hiding this comment.
Should we report error for the else branch ?
|
Thanks @fsk119 @danny0405 for the review, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Migrate Hive connector to new table source sink interface
Brief change log
HiveTableFactoryHive logicalHiveDynamicTableFactoryHiveTableSourceHiveTableSinkVerifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation