Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-1994] [ml] Add different gain calculation schemes to SG #1384

Closed
wants to merge 2 commits into from

Conversation

rawkintrevo
Copy link
Contributor

Added 5 gain calculation schemes and .setOptimization method which takes an int values 0-5.

@tillrohrmann
Copy link
Contributor

Hi @rawkintrevo, thanks for your contribution.

You have some scala style violations in GradientDescent.scala line 46 and 168. The lines mustn't be longer than 100 characters as the maven log output indicates.

Furthermore, could you change the title to the format "[FLINK-1994] [ml] Add different gain calculation schemes to SGD". That way, the JIRA issues will be automatically updated with the what happens on Github.

In Flink, we always rebase our changes on top of the current master branch. Therefore, it would be good if you could revert the last merge commit. If you want to update on the latest master, then do a rebase and a force push to the branch in your repository (here master).

@rawkintrevo rawkintrevo changed the title Flink 1994- Add different gain calculation schemes to SGD [FLINK-1994] [ml] Add different gain calculation schemes to SG Nov 24, 2015
@rawkintrevo
Copy link
Contributor Author

did what you said ( I think ) and opened a new pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants