[FLINK-19908][table-planner-blink] FlinkLogicalTableSourceScan and CommonPhysicalTableSourceScan should respect source reuse config option #13869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmonPhysicalTableSourceScan should respect source reuse config option
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 310c53e (Sun Nov 01 17:14:08 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
godfreyhe
reviewed
Nov 1, 2020
Comment on lines
453
to
481
| def testEnableReuseTableSourceOnNewSource(): Unit = { | ||
| util.tableEnv.getConfig.getConfiguration.setBoolean( | ||
| OptimizerConfigOptions.TABLE_OPTIMIZER_REUSE_SOURCE_ENABLED, true) | ||
| addNewSource() | ||
| val sqlQuery = | ||
| """ | ||
| |WITH t AS ( | ||
| | SELECT newX.a AS a, newX.b AS b, newY.d AS d, newY.e AS e | ||
| | FROM newX, newY | ||
| | WHERE newX.a = newY.d) | ||
| |SELECT t1.*, t2.* FROM t t1, t t2 WHERE t1.b = t2.e AND t1.a < 10 AND t2.a > 5 | ||
| """.stripMargin | ||
| util.verifyPlan(sqlQuery) | ||
| } | ||
|
|
||
| @Test | ||
| def testDisableReuseTableSourceOnNewSource(): Unit = { | ||
| util.tableEnv.getConfig.getConfiguration.setBoolean( | ||
| OptimizerConfigOptions.TABLE_OPTIMIZER_REUSE_SOURCE_ENABLED, false) | ||
| addNewSource() | ||
| val sqlQuery = | ||
| """ | ||
| |WITH t AS ( | ||
| | SELECT newX.a AS a, newX.b AS b, newY.d AS d, newY.e AS e | ||
| | FROM newX, newY | ||
| | WHERE newX.a = newY.d) | ||
| |SELECT t1.*, t2.* FROM t t1, t t2 WHERE t1.b = t2.e AND t1.a < 10 AND t2.a > 5 | ||
| """.stripMargin | ||
| util.verifyPlan(sqlQuery) |
There was a problem hiding this comment.
extract them into a common method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Currently we have the
table.optimizer.reuse-sub-plan-enabledconfig option to configure the reuse of sources. HoweverFlinkLogicalTableSourceScanandCommonPhysicalTableSourceScando not respect this option and are always reused.This PR fixes the related code in
SubplanReuserso thatFlinkLogicalTableSourceScanandCommonPhysicalTableSourceScannow respect the config option,Brief change log
FlinkLogicalTableSourceScanandCommonPhysicalTableSourceScannow respect the config optionVerifying this change
This change added tests and can be verified by running the added tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation