-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-19919][runtime] Remove legacy scheduling in ExecutionGraph components #13882
[FLINK-19919][runtime] Remove legacy scheduling in ExecutionGraph components #13882
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 8e08d72 (Mon Nov 02 11:51:51 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
8e08d72
to
cdeecd5
Compare
cdeecd5
to
b15be6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…raph on starting SchedulerBase This allows us to create an ExecutionGraph with InternalTaskFailuresListener assigned without having to start scheduling it. It is required to rework some tests to be based on new scheduler.
…o createSchedulerBuilder(...) because it returns a builder
…or() to #initialize() This is to reduce confusion because the method also does other initialization work.
…pdates TaskManagerLocation to enable comparing LocalTaskManagerLocation
…d RestartTimeGaugeTest ExecutionGraphMetricsTest can be superseded by the newly added RestartTimeGaugeTest and DefaultSchedulerTest#jobStatusIsRestartingIfOneVertexIsWaitingForRestart().
…scheduler and remove those which are not needed anymore
…anceled when a vertex is failed or canceled
…uests will be canceled when SlotPool is shutdown
…operly restarted on slot allocation failures
b15be6a
to
1d58931
Compare
What is the purpose of the change
This PR is to remove legacy scheduling in ExecutionGraph components.
It is based on #13641
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation