Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-19919][runtime] Remove legacy scheduling in ExecutionGraph components #13882

Closed

Conversation

zhuzhurk
Copy link
Contributor

@zhuzhurk zhuzhurk commented Nov 2, 2020

What is the purpose of the change

This PR is to remove legacy scheduling in ExecutionGraph components.
It is based on #13641

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 2, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8e08d72 (Mon Nov 02 11:51:51 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 2, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@zhuzhurk zhuzhurk force-pushed the FLINK_19919_remove_legacy_scheduling branch from 8e08d72 to cdeecd5 Compare November 2, 2020 14:41
@zhuzhurk zhuzhurk force-pushed the FLINK_19919_remove_legacy_scheduling branch from cdeecd5 to b15be6a Compare November 18, 2020 09:41
@tillrohrmann tillrohrmann self-assigned this Dec 11, 2020
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @zhuzhurk. The removal looks good to me. +1 for merging after merging #13641.

…raph on starting SchedulerBase

This allows us to create an ExecutionGraph with InternalTaskFailuresListener assigned without having to start scheduling it. It is required to rework some tests to be based on new scheduler.
…o createSchedulerBuilder(...) because it returns a builder
…or() to #initialize()

This is to reduce confusion because the method also does other initialization work.
…pdates TaskManagerLocation to enable comparing LocalTaskManagerLocation
…d RestartTimeGaugeTest

ExecutionGraphMetricsTest can be superseded by the newly added RestartTimeGaugeTest and DefaultSchedulerTest#jobStatusIsRestartingIfOneVertexIsWaitingForRestart().
…scheduler and remove those which are not needed anymore
…uests will be canceled when SlotPool is shutdown
…operly restarted on slot allocation failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants