[FLINK-13733][connector/kafka] Make FlinkKafkaInternalProducerITCase more robust

[PatrickRen]

What is the purpose of the change

This pull request adds error checking and retry strategy for FlinkKafkaInternalProducerITCase to make it more robust.

Brief change log

• Add error checking in kafkaProducer.send() callback.
• Add retry for kafkaConsumer.poll() if nothing is retrieved from Kafka brokers in assertRecord().

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 685a334 (Tue Nov 10 16:13:08 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[PatrickRen]

Hi @becketqin , I think the modification you made in your own repo has already covered my thought of extending the timeout of kafkaConsumer.poll(), so I just cherry-picked your commit here.

Also I tried to run testHappyPath locally on my laptop after applying your changes this afternoon, and it failed again after two hours repeatedly running because of a JUnit timeout. I checked the log and found nothing special. I'll extend the JUnit timeout to 60 seconds and try again tonight.

[flinkbot]

CI report:

• 685a334 Azure: SUCCESS
• 6b18191 Azure: PENDING

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[PatrickRen]

Looks like increasing the JUnit timeout to 60 secs indeed helps. I ran this case repeatedly for over 300 times locally on my laptop and everything looks good. @becketqin Will you help to look at this PR? Thank you~

[becketqin]

@PatrickRen Thanks a lot for the thorough tests. The patch LGTM.

[becketqin]

Merged to master.
cb2d137