Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-20292][doc] Improve the document about table formats overlap in user fat jar #14229

Merged
merged 1 commit into from Dec 3, 2020

Conversation

leonardBang
Copy link
Contributor

What is the purpose of the change

  • Currently, Flink can not load the right format factory if users' fat jar using more than one format, the reason is the SPI configuration file META/services will overlap each other. User can use maven shade plugin to skip this issue, this pull request improves the document about table formats overlap in user fat jar,

Brief change log

  • Add note about using maven shade plugin to skip formats configuration files overlap in table formats overview page.

Verifying this change

This change is a document improvement without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@leonardBang
Copy link
Contributor Author

cc : @gaoyunhaii Appreciate if you can take a look this PR.

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1043b59 (Thu Nov 26 08:55:19 UTC 2020)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 26, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@gaoyunhaii
Copy link
Contributor

Very thanks @leonardBang for opening the PR ! I thought that we may also

  1. Explicitly adding codes to show how to configure maven shaded plugin under the description.
  2. Links to this section from the specific format pages (like avro) under the Dependencies section so that users jump to specific pages could also see the warnings.

How do you think about that ?

@leonardBang
Copy link
Contributor Author

Very thanks @leonardBang for opening the PR ! I thought that we may also

  1. Explicitly adding codes to show how to configure maven shaded plugin under the description.
  2. Links to this section from the specific format pages (like avro) under the Dependencies section so that users jump to specific pages could also see the warnings.

How do you think about that ?

make sense to me, will update the PR

@leonardBang
Copy link
Contributor Author

@gaoyunhaii Appreciate if you can take a look ^_^.

docs/dev/table/connectors/formats/avro-confluent.md Outdated Show resolved Hide resolved
docs/dev/table/connectors/formats/canal.md Outdated Show resolved Hide resolved
docs/dev/table/connectors/formats/canal.zh.md Outdated Show resolved Hide resolved
docs/dev/table/connectors/formats/debezium.md Outdated Show resolved Hide resolved
docs/dev/table/connectors/formats/debezium.zh.md Outdated Show resolved Hide resolved
docs/dev/table/connectors/formats/index.md Outdated Show resolved Hide resolved
docs/dev/table/connectors/formats/index.md Outdated Show resolved Hide resolved
docs/dev/table/connectors/formats/index.md Outdated Show resolved Hide resolved
@leonardBang
Copy link
Contributor Author

@gaoyunhaii Could you have a more look?

Copy link
Contributor

@gaoyunhaii gaoyunhaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thanks @leonardBang for the updates ! The PR looks good to me now and +1 for merge!

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi
Copy link
Contributor

Links to this section from the specific format pages (like avro) under the Dependencies section so that users jump to specific pages could also see the warnings.

I think this is a little redundant, we don't need add same words in every formats, what do you think? @gaoyunhaii @leonardBang

@gaoyunhaii
Copy link
Contributor

From my side of view I still tend to keep the links since that if users want to add the dependency of one format, he would tend to jump to the corresponding page to see how to add the dependency, without read the index page first.

@leonardBang
Copy link
Contributor Author

I think we need add a section for connector/index page.
And do we to add NOTE for every connector and format ? I tend to do not, building an uber-jar is not necessary for SQL user, many user case is downloading the connector jar and format jar directly, if user's project contains multiple connectors/formats, I think user will read connectors/formats matrix in index page.

@gaoyunhaii
Copy link
Contributor

gaoyunhaii commented Dec 3, 2020

Ok, got it, if building an uber-jar is not necessary for SQL user, then I think it should be ok to not add the note. Very thanks for the information!

@leonardBang
Copy link
Contributor Author

@gaoyunhaii @JingsongLi Updated as discussed

@JingsongLi
Copy link
Contributor

Looks good to me. Thanks @leonardBang and @gaoyunhaii , merging...

@JingsongLi JingsongLi merged commit 25b07f1 into apache:master Dec 3, 2020
JingsongLi pushed a commit that referenced this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants