New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-20292][doc] Improve the document about table formats overlap in user fat jar #14229
Conversation
cc : @gaoyunhaii Appreciate if you can take a look this PR. |
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 1043b59 (Thu Nov 26 08:55:19 UTC 2020) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Very thanks @leonardBang for opening the PR ! I thought that we may also
How do you think about that ? |
make sense to me, will update the PR |
1043b59
to
7d520e2
Compare
@gaoyunhaii Appreciate if you can take a look ^_^. |
7d520e2
to
6538092
Compare
6538092
to
1fb988b
Compare
@gaoyunhaii Could you have a more look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very thanks @leonardBang for the updates ! The PR looks good to me now and +1 for merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I think this is a little redundant, we don't need add same words in every formats, what do you think? @gaoyunhaii @leonardBang |
From my side of view I still tend to keep the links since that if users want to add the dependency of one format, he would tend to jump to the corresponding page to see how to add the dependency, without read the index page first. |
I think we need add a section for connector/index page. |
Ok, got it, if building an uber-jar is not necessary for SQL user, then I think it should be ok to not add the note. Very thanks for the information! |
…format SPI resource files
1fb988b
to
b6cb320
Compare
@gaoyunhaii @JingsongLi Updated as discussed |
Looks good to me. Thanks @leonardBang and @gaoyunhaii , merging... |
…format SPI resource files This closes #14229
What is the purpose of the change
SPI
configuration fileMETA/services
will overlap each other. User can use maven shade plugin to skip this issue, this pull request improves the document about table formats overlap in user fat jar,Brief change log
Verifying this change
This change is a document improvement without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation