[FLINK-20365][python] The native k8s cluster could not be unregistered when executing Python DataStream application in attach mode #14232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d when executing Python DataStream application attachedly.
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit ef93e27 (Thu Nov 26 09:43:48 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
dianfu
approved these changes
Nov 26, 2020
There was a problem hiding this comment.
@shuiqiangchen Thanks a lot for the fixing. LGTM. Just two minor comments. I will address them during merging the PR.
| @@ -375,4 +379,10 @@ static Process launchPy4jPythonClient( | |||
| // start the python process. | |||
| return PythonEnvUtils.startPythonProcess(pythonEnv, commands, redirectToPipe); | |||
| } | |||
|
|
|||
| public static void setPythonException(Exception pythonException) { | |||
There was a problem hiding this comment.
Suggested change
| public static void setPythonException(Exception pythonException) { | |
| public static void setPythonException(Throwable pythonException) { |
| @@ -106,9 +105,11 @@ public static void main(String[] args) throws ExecutionException, InterruptedExc | |||
| } catch (Throwable e) { | |||
| LOG.error("Run python process failed", e); | |||
|
|
|||
| // throw ProgramAbortException if the caller is interested in the program plan, | |||
There was a problem hiding this comment.
the comments could be kept.
dianfu
changed the title
|
closed via af1b2cf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The native k8s cluster could not be unregistered when executing Python DataStream application attachedly.
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation