[FLINK-20389][tests] Fix UnalignedCheckpointITCase to work with unassigned splits. #14250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igned splits. The test currently assumed that when induced failures happen, splits have been assigned to readers, which works fine for the planned snapshot-failure-recovery sequence. However, when unexpected failures happen, this assumption does not necessarily hold resulting in failures that may impede investigations. The test would still fail as the number of failures would be different from the expected numbers of failures, but investigation can focus on the unexpected failure then.
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 12672b4 (Fri Nov 27 10:55:00 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
| if (split != null) { | ||
| LOG.info("notifyCheckpointComplete {} @ {} subtask (? attempt)", split.numCompletedCheckpoints, split.nextNumber % split.increment); |
There was a problem hiding this comment.
Can split.increment be 0 here?
There was a problem hiding this comment.
Increment = parallelism, so it would be a bug at a different point. But good question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The test currently assumed that when induced failures happen, splits have been assigned to readers, which works fine for the planned snapshot-failure-recovery sequence.
However, when unexpected failures happen, this assumption does not necessarily hold resulting in failures that may impede investigations.
The test would still fail as the number of failures would be different from the expected numbers of failures, but investigation can focus on the unexpected failure then.
Brief change log
Verifying this change
This commit is fixing a test.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation