[FLINK-19530] Reorganise contents of Table API concepts #14257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ming concepts to a new section
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit dd3187b (Sun Nov 29 06:01:04 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
KKcorps
changed the title
sjwiesman
requested changes
Nov 30, 2020
There was a problem hiding this comment.
I am going to do a proper review tomorrow but a few notes:
- There is a merge conflict that needs to be resolved, please rebase on master
- In general, please put the ticket in the commit message
- Please move the files back to where they were. Everything under the streaming folder is relevant for unbounded processing and moving the files breaks links to our docs. I don't think there is any need for the additional subsection.
| After [defining temporal table function](temporal_tables.html#defining-temporal-table-function), we can start using it. | ||
| Temporal table functions can be used in the same way as normal table functions would be used. | ||
| To simplify such queries, Flink offers [Temporal Functions](../temporal_tables.html). For this example, we define a temporal function `Rates` as follows : | ||
| //TODO |
There was a problem hiding this comment.
We can't merge in todo's
There was a problem hiding this comment.
My bad. Seems like IntelliJ settings got messed up. Removing them manually.
sjwiesman
requested changes
Dec 2, 2020
| @@ -36,6 +36,14 @@ For the changing dimension table, Flink allows for accessing the content of the | |||
| Motivation | |||
| ---------- | |||
There was a problem hiding this comment.
temporal tables got a lot of new features in 1.12. Please rebase, unfortunately, a lot of what you did is no longer relevant.
|
|
||
| For more information regarding the syntax, please check the join sections in [Table API](../tableApi.html#joins) and [SQL]({{ site.baseurl }}/dev/table/sql/queries.html#joins). | ||
|
|
||
| //TODO: Explain the complications of unbounded joins |
Comment on lines
+35
to
37
| Regular Joins and its challenges | ||
| --------------------------------------- | ||
|
|
There was a problem hiding this comment.
Lets get rid of "and its challenges". We want to make flink more approachable :)
| @@ -351,4 +339,20 @@ FROM | |||
|
|
|||
| <span class="label label-danger">Attention</span> Flink does not support event time temporal table joins currently. | |||
|
|
|||
| ### Temporal Table joins vs Other joins | |||
|
|
|||
| In contrast to [regular joins](#regular-joins), the previous results of the temporal table join will not be affected despite the changes on the build side. Also, the temporal table join operator is very lightweight and does not keep any state. | |||
There was a problem hiding this comment.
Also doesn't sound right here.
Suggested change
| In contrast to [regular joins](#regular-joins), the previous results of the temporal table join will not be affected despite the changes on the build side. Also, the temporal table join operator is very lightweight and does not keep any state. | |
| In contrast to [regular joins](#regular-joins), the previous results of the temporal table join will not be affected despite the changes on the build side. The temporal table join operator is very lightweight and does not keep any state. |
|
|
||
| In contrast to [regular joins](#regular-joins), the previous results of the temporal table join will not be affected despite the changes on the build side. Also, the temporal table join operator is very lightweight and does not keep any state. | ||
|
|
||
| Compared to [interval joins](#interval-joins), temporal table joins do not define a time window within which the records will be joined. |
There was a problem hiding this comment.
again, 1.12 added support for temporal event time table joins so this needs to be updated.
The FLIP-60 mentions a new section for unbounded data processing. I Will revert to older structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR involves the following changes -