New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-19659][table-planner] Array type supports equals and not_equal… #14328
base: master
Are you sure you want to change the base?
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit b4a79b0 (Tue Dec 08 07:38:24 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@@ -94,10 +94,33 @@ class ScalarOperatorsTest extends ScalarOperatorsTestBase { | |||
"x'68656C6C6F20636F6465' > x'68656C6C6F2063617374'", | |||
"true") | |||
|
|||
// between array and array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wangxlong. I will do a full review soon. Could you use the new test base?
org.apache.flink.table.planner.functions.CastFunctionITCase
It was recently added for casting rows to rows. It will be further extended as part of FLINK-17321.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @twalthr. Yes, I will update it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ready to be reviewed. Thanks for having a look in your free time. @twalthr
3a6af81
to
d05d4f7
Compare
…s operator when element types are different but castable
What is the purpose of the change
Array type supports equals and not_equals operator when element types are different but castable
Brief change log
Add the cast code between array and array
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation