Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-3113] Remove unused and unsupported global-order methods from GenericDataSinkBase #1435

Closed
wants to merge 1 commit into from
Closed

[FLINK-3113] Remove unused and unsupported global-order methods from GenericDataSinkBase #1435

wants to merge 1 commit into from

Conversation

fhueske
Copy link
Contributor

@fhueske fhueske commented Dec 4, 2015

Methods are unused and not supported by DataSet API.

@fhueske
Copy link
Contributor Author

fhueske commented Dec 7, 2015

Any objections against merging this PR?

@StephanEwen
Copy link
Contributor

+1, please merge

Should we also remove the DataDistribution class? We can revamp it in a better form with the global sorting pull request...

@fhueske
Copy link
Contributor Author

fhueske commented Dec 7, 2015

DataDistribution is actually adapted and used in the range partition PR #1255.

@StephanEwen
Copy link
Contributor

Makes sense...

@fhueske
Copy link
Contributor Author

fhueske commented Dec 7, 2015

Going to merge this PR.

@asfgit asfgit closed this in 9547f08 Dec 8, 2015
@fhueske fhueske deleted the globalOrderSinkCleanUp branch January 14, 2016 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component=<none>
Projects
None yet
Milestone
No milestone
3 participants
@fhueske @StephanEwen @rmetzger