Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-3147] HadoopOutputFormatBase should expose mutexes for subclasses #1442

Closed

Conversation

ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Dec 8, 2015

Simple patch.

@ndimiduk ndimiduk force-pushed the 3147-hadoopoutputformatbase-mutexes branch from 94701d1 to 333aa03 Compare December 8, 2015 19:19
@fhueske
Copy link
Contributor

fhueske commented Dec 8, 2015

Thanks for the patch!

Can you apply the same changes to org.apache.flink.api.java.hadoop.mapred.HadoopOutputFormatBase, the base class for mapred API OutputFormats?

@ndimiduk ndimiduk force-pushed the 3147-hadoopoutputformatbase-mutexes branch from 333aa03 to 27851fa Compare December 8, 2015 20:36
@ndimiduk
Copy link
Member Author

ndimiduk commented Dec 8, 2015

Sure thing.

@hsaputra
Copy link
Contributor

hsaputra commented Dec 9, 2015

+1
LGTM

@rmetzger
Copy link
Contributor

+1 to merge

@fhueske
Copy link
Contributor

fhueske commented Dec 15, 2015

Thanks for the PR! I'll merge it.

@ndimiduk
Copy link
Member Author

Should I post a second PR for merging to 0.10-SNAPSHOT, or will you handle cherry-pick to active release branches? Thanks a lot @fhueske !

@fhueske
Copy link
Contributor

fhueske commented Dec 15, 2015

I will cherry-pick the commit over to the 0.10 branch. Thanks @ndimiduk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants