-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18090] Update the Row.toString method #14568
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 7b8a1e7 (Fri May 28 07:02:10 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 % Azure
@@ -74,6 +74,8 @@ public static boolean compareRows(List<Row> l1, List<Row> l2, boolean ignoreOrde | |||
// Internal utilities | |||
// -------------------------------------------------------------------------------------------- | |||
|
|||
public static boolean USE_LEGACY_TO_STRING = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a note it should be used only in tests?
This updates the Row.toString method to provide a good summary string. In particular it fixes the following issues: Changeflag: According to FLIP-95, a row describes an entry in a changelog. Therefore, it should visible whether a row is an insert, delete, or update change. Now indicated with +I, -D, +U, -U. Nested rows: In the old implementation it was not visible whether nested rows exist or not due to missing start/end boundaries. Now indicated with [...] or {...}. Positioned rows vs. named rows: According to FLIP-136, it should be visible whether a row operates in name-based or position-based field mode. Now indicated with [...] or {...}. Nested arrays in maps and lists: In the old implementation arrays in maps or lists could not be represented. Wrong formatting: Most programming languages use a space after a comma. This is an incompatible change. If the legacy representation is still required for tests, the old behavior can be restored via the flag RowUtils.USE_LEGACY_TO_STRING for the local JVM. However, relying on the row's string representation for tests is not a good idea in general as field data types are not verified.
All tests in modules apart from the Blink planner/runtime module have been updated. Otherwise we use a JUnit rule to make the migration of the remaining tests incremental. This closes apache#14568.
All tests in modules apart from the Blink planner/runtime module have been updated. Otherwise we use a JUnit rule to make the migration of the remaining tests incremental. This closes apache#14568.
What is the purpose of the change
This updates the
Row.toString
method to provide a good summary string.In particular it fixes the following issues:
+I
,-D
,+U
,-U
.[...]
or{...}
.[...]
or{...}
.Brief change log
Because this change might cause issues for tests, we provide a flag in
RowUtils
for legacy mode and a JUnit rule to make the migration incremental.All tests in modules apart from the Blink planner/runtime module have been updated.
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: yesDocumentation