New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-20892] Remove ScheduledUnit #14580
Conversation
… corresponding classes, and test cases. Comments were adapted accordingly.
…nding test class SlotSharingManagerTest.
Delete unused InputDependencyConstraintChecker and related test class InputDependencyConstraintCheckerTest. FLINK-20589
DefaultSchedulerTest.testInputConstraintAllPerf() is removed as InputDependencyContraint is not used anymore. FLINK-20589
SchedulingExecutionVertex.[set|get]InputDependencyConstraint() is removed as InputDependencyContraint is not used anymore. FLINK-20589
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit e007381 (Fri May 28 07:04:26 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
ExeucutorUtils.setBatchProperties(StreamExecutionEnvironment) does not set InputDependencyContraint anymore as it's not used anywhere. FLINK-20589
JobGraphGenerator does not set the InputDependencyConstraint for each vertex, anymore as it's not used anywhere. FLINK-20589
a1dccd1
to
c71b97f
Compare
c71b97f
to
1ec3a4a
Compare
1ec3a4a
to
e007381
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal is quite simple. It's good that all the usages of ScheduledUnit
have been removed in previous refactoring work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge soon
What is the purpose of the change
Removes
ScheduledUnit
andDummyScheduledUnit
as both are not being used anymore.This PR depends on PR #14579 covering FLINK-20619 being merged.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation