-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-20832][docs] Deliver bootstrap css and js ourselves #14583
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 4a04180 (Fri May 28 07:03:23 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Thanks for opening the PR. Have you checked the licenses of the font files? |
@rmetzger , no, I just download them from the bootstrap CDN url. |
It's mentioned in the |
/*! | ||
* Bootstrap v3.3.4 (http://getbootstrap.com) | ||
* Copyright 2011-2015 Twitter, Inc. | ||
* Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should mention this dependency in the NOTICE
file and add a copy of the license to licenses/LICENSE.bootstrap
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
@rmetzger , I removed |
But it seems that we are loading anchor.min.js from a cloudflare CDN. |
Co-authored-by: Robert Metzger <89049+rmetzger@users.noreply.github.com>
@rmetzger I have added back the anchorjs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing this!
What is the purpose of the change
Delivering the required files ourselves, instead of using a CDN to fix the unstable https://maxcdn.bootstrapcdn.com in China.
Brief change log
docs/page/...
base.html
.Verifying this change
I shutdowned the network on my machine, and locally build the docs, and everything works well.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation