Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-20850][runtime] Removing usage of CoLocationConstraints #14584

Closed
wants to merge 18 commits into from

Commits on Jan 11, 2021

  1. [FLINK-20850][runtime] Remove ensureCoLocatedVerticesInSameRegion

    Removed DefaultExecutionTopology.ensureCoLocatedVerticesInSameRegion(..) as
    CoLocationConstraint is not used anymore.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    d2cd2fc View commit details
    Browse the repository at this point in the history
  2. [FLINK-20850][runtime] Remove CoLocationConstraint

    Remove CoLocationConstraint from ExeuctionVertexSchedulingRequirements as it is
    not used anymore.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    e676e69 View commit details
    Browse the repository at this point in the history
  3. [FLINK-20850][runtime] Remove CoLocationConstraint-related test

    This test verifies that the CoLocationConstraint is reset when recovering the
    task. We still need to verify whether it should be replaced.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    d606bd9 View commit details
    Browse the repository at this point in the history
  4. [FLINK-20850][runtime] Remove CoLocationConstraint-related test

    This test verifies that the CoLocationConstraints are created which is not the
    case anymore.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    343d47f View commit details
    Browse the repository at this point in the history
  5. [FLINK-20850][runtime] Remove CoLocation information from ExecutionVe…

    …rtex
    
    The CoLocation information isn't processed through the ExecutionVertex anymore
    but is calculated statically by the LocalInputPreferredSlotSharingStrategy.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    5bd6cd9 View commit details
    Browse the repository at this point in the history
  6. [FLINK-20850][runtime] Remove CoLocationConstraintTest

    The CoLocationConstraints are not used anymore but replaced by
    LocalInputPreferredSlotSharingStrategy.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    f4dcfd1 View commit details
    Browse the repository at this point in the history
  7. [FLINK-20850][runtime] Remove CoLocationConstraint from CoLocationGroup

    The CoLocationConstraints is not used anymore and, therefore, can be removed
    from the CoLocationGroup.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    3645bcd View commit details
    Browse the repository at this point in the history
  8. [FLINK-20850][runtime] Remove CoLocationConstraint

    CoLocationConstraint is deleted. Its JavaDoc is copied over to
    CoLocationConstraintDesc and adjusted accordingly.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    22d847b View commit details
    Browse the repository at this point in the history
  9. [FLINK-20850][runtime] Make CoLocationGroupDesc an interface

    The CoLocationGroup only needs to be adapted within JobVertex. Any other
    locations can rely on CoLocationGroupDesc's read-only methods.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    b062aa5 View commit details
    Browse the repository at this point in the history
  10. [FLINK-20850][runtime] Minor cleanup

    Minor cleanup to follow Intellij suggestions.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    af31e07 View commit details
    Browse the repository at this point in the history
  11. [FLINK-20850][runtime] Cleans up resetForNewExecution

    Previously, the CoLocationConstraints have been reset in this method. The
    CoLocationGroup handling is not needed anymore after the reset functionality
    was removed.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    ea4f9d4 View commit details
    Browse the repository at this point in the history
  12. [FLINK-20850][runtime] Replace CoLocationGroup by corresponding inter…

    …face
    
    The interface CoLocationGroupDesc was introduced wherever possible.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    ad854e3 View commit details
    Browse the repository at this point in the history
  13. [FLINK-20850][runtime] Revert 8b1510c

    We need to ensure that co-located tasks are executed in the same pipeline
    region. Hence, 8b1510c was reverted.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    ddfcfed View commit details
    Browse the repository at this point in the history
  14. [FLINK-20850][runtime] Renames method

    CoLocationGroupDesc.getVertices was renamed: The refactoring changed the return
    type and, therefore, made the renaming necessary.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    f1b2df2 View commit details
    Browse the repository at this point in the history
  15. [FLINK-20850][runtime] Fix failing test

    The old implementation relied on the CoLocationConstraint only being created
    once. Switching to CoLocationConstraintDesc changed that behavior. Hence, we
    have to switch from IdentityHashMap to HashMap.
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    55c1b41 View commit details
    Browse the repository at this point in the history
  16. [FLINK-20850][runtime] Rename classes and interfaces

    After finalizing the refactoring of removing CoLocationConstraint and making
    CoLocationGroupDesc an interface, it is now reasonable to rename the affected
    classes and interfaces accordingly:
    * CoLocationGroup -> CoLocationGroupImpl
    * CoLocationGroupDesc -> CoLocationGroup
    * CoLocationConstraintDesc -> CoLocationConstraint
    
    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    acb1f1d View commit details
    Browse the repository at this point in the history
  17. [FLINK-20850][runtime] Typo fix

    FLINK-20589
    XComp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    7dea123 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. [FLINK-20850][runtime] Apply renamings

    Minor renamings are applied that were brought up during the review.
    Additionally, missing JavaDoc was added.
    XComp committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    51e4355 View commit details
    Browse the repository at this point in the history