New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-20850][runtime] Removing usage of CoLocationConstraints #14584
Commits on Jan 11, 2021
-
[FLINK-20850][runtime] Remove ensureCoLocatedVerticesInSameRegion
Removed DefaultExecutionTopology.ensureCoLocatedVerticesInSameRegion(..) as CoLocationConstraint is not used anymore. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for d2cd2fc - Browse repository at this point
Copy the full SHA d2cd2fcView commit details -
[FLINK-20850][runtime] Remove CoLocationConstraint
Remove CoLocationConstraint from ExeuctionVertexSchedulingRequirements as it is not used anymore. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for e676e69 - Browse repository at this point
Copy the full SHA e676e69View commit details -
[FLINK-20850][runtime] Remove CoLocationConstraint-related test
This test verifies that the CoLocationConstraint is reset when recovering the task. We still need to verify whether it should be replaced. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for d606bd9 - Browse repository at this point
Copy the full SHA d606bd9View commit details -
[FLINK-20850][runtime] Remove CoLocationConstraint-related test
This test verifies that the CoLocationConstraints are created which is not the case anymore. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for 343d47f - Browse repository at this point
Copy the full SHA 343d47fView commit details -
[FLINK-20850][runtime] Remove CoLocation information from ExecutionVe…
…rtex The CoLocation information isn't processed through the ExecutionVertex anymore but is calculated statically by the LocalInputPreferredSlotSharingStrategy. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for 5bd6cd9 - Browse repository at this point
Copy the full SHA 5bd6cd9View commit details -
[FLINK-20850][runtime] Remove CoLocationConstraintTest
The CoLocationConstraints are not used anymore but replaced by LocalInputPreferredSlotSharingStrategy. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for f4dcfd1 - Browse repository at this point
Copy the full SHA f4dcfd1View commit details -
[FLINK-20850][runtime] Remove CoLocationConstraint from CoLocationGroup
The CoLocationConstraints is not used anymore and, therefore, can be removed from the CoLocationGroup. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for 3645bcd - Browse repository at this point
Copy the full SHA 3645bcdView commit details -
[FLINK-20850][runtime] Remove CoLocationConstraint
CoLocationConstraint is deleted. Its JavaDoc is copied over to CoLocationConstraintDesc and adjusted accordingly. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for 22d847b - Browse repository at this point
Copy the full SHA 22d847bView commit details -
[FLINK-20850][runtime] Make CoLocationGroupDesc an interface
The CoLocationGroup only needs to be adapted within JobVertex. Any other locations can rely on CoLocationGroupDesc's read-only methods. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for b062aa5 - Browse repository at this point
Copy the full SHA b062aa5View commit details -
[FLINK-20850][runtime] Minor cleanup
Minor cleanup to follow Intellij suggestions. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for af31e07 - Browse repository at this point
Copy the full SHA af31e07View commit details -
[FLINK-20850][runtime] Cleans up resetForNewExecution
Previously, the CoLocationConstraints have been reset in this method. The CoLocationGroup handling is not needed anymore after the reset functionality was removed. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for ea4f9d4 - Browse repository at this point
Copy the full SHA ea4f9d4View commit details -
[FLINK-20850][runtime] Replace CoLocationGroup by corresponding inter…
…face The interface CoLocationGroupDesc was introduced wherever possible. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for ad854e3 - Browse repository at this point
Copy the full SHA ad854e3View commit details -
[FLINK-20850][runtime] Revert 8b1510c
We need to ensure that co-located tasks are executed in the same pipeline region. Hence, 8b1510c was reverted. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for ddfcfed - Browse repository at this point
Copy the full SHA ddfcfedView commit details -
[FLINK-20850][runtime] Renames method
CoLocationGroupDesc.getVertices was renamed: The refactoring changed the return type and, therefore, made the renaming necessary. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for f1b2df2 - Browse repository at this point
Copy the full SHA f1b2df2View commit details -
[FLINK-20850][runtime] Fix failing test
The old implementation relied on the CoLocationConstraint only being created once. Switching to CoLocationConstraintDesc changed that behavior. Hence, we have to switch from IdentityHashMap to HashMap. FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for 55c1b41 - Browse repository at this point
Copy the full SHA 55c1b41View commit details -
[FLINK-20850][runtime] Rename classes and interfaces
After finalizing the refactoring of removing CoLocationConstraint and making CoLocationGroupDesc an interface, it is now reasonable to rename the affected classes and interfaces accordingly: * CoLocationGroup -> CoLocationGroupImpl * CoLocationGroupDesc -> CoLocationGroup * CoLocationConstraintDesc -> CoLocationConstraint FLINK-20589
Configuration menu - View commit details
-
Copy full SHA for acb1f1d - Browse repository at this point
Copy the full SHA acb1f1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dea123 - Browse repository at this point
Copy the full SHA 7dea123View commit details
Commits on Jan 12, 2021
-
[FLINK-20850][runtime] Apply renamings
Minor renamings are applied that were brought up during the review. Additionally, missing JavaDoc was added.
Configuration menu - View commit details
-
Copy full SHA for 51e4355 - Browse repository at this point
Copy the full SHA 51e4355View commit details