New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-20921][python] Support SqlTimeTypeInfo in Python DataStream #14607
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 0350eeb (Fri May 28 07:07:07 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a little redundant code in test cases that could be cleaned up.
self.env.execute("test sql timestamp type info") | ||
results = self.test_sink.get_results() | ||
expected = ['+I[2021-01-09, 12:00:00, 2021-01-09 12:00:00.011]'] | ||
results.sort() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sorts is unnecessary.
@WeiZhong94 Thanks a lot for the review. I have addressed the comments at the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…taStream API This closes apache#14607.
What is the purpose of the change
This pull request Support SqlTimeTypeInfo in Python DataStream
Brief change log
Verifying this change
This change added tests and can be verified as follows:
PythonTypeUtilsTest
test_sql_timestamp_type_info
intest_data_stream.py
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation