New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-21149][table-common] Remove deprecated CatalogBaseTable.getProperties() #14759
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 925f581 (Fri May 28 08:17:43 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very straightforward! Looks good to merge. 👌
One question: who will this change affect? Only authors of custom catalog bindings?
Thanks @aljoscha. Yes, it only affects custom catalog implementers. But even those had the chance to update to |
What is the purpose of the change
This removes the deprecated
CatalogBaseTable.getProperties()
withCatalogBaseTable.getOptions()
and makes sure that we have a clear distinction between options (the WITH part of a CREATE TABLE) and properties (a general Map<String, String> and the full CREATE TABLE when persisting).Brief change log
CatalogBaseTable.getProperties()
AlterTableProperties
toAlterTableOptions
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: yesDocumentation