[FLINK-20994][python] Add public method to create TableEnvironment in PyFlink. #14760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 2934d01 (Tue Jan 26 13:15:21 UTC 2021) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
WeiZhong94
force-pushed
the
FLINK-20994
branch
from
a1a7732
to
a2dbd92
Compare
HuangXingBo
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
@WeiZhong94 Thanks a lot for the PR. LGTM. I only left a minor code style suggestion.
| @@ -1045,7 +1059,8 @@ def register_java_function(self, name: str, function_class_name: str): | |||
| .loadClass(function_class_name).newInstance() | |||
| # this is a temporary solution and will be unified later when we use the new type | |||
| # system(DataType) to replace the old type system(TypeInformation). | |||
| if self._is_blink_planner and isinstance(self, BatchTableEnvironment): | |||
| if self._is_blink_planner and not isinstance(self, StreamTableEnvironment) \ | |||
| or self._unified: | |||
| @@ -1090,7 +1105,8 @@ def register_function(self, name: str, function: UserDefinedFunctionWrapper): | |||
| java_function = function._java_user_defined_function() | |||
| # this is a temporary solution and will be unified later when we use the new type | |||
| # system(DataType) to replace the old type system(TypeInformation). | |||
| if self._is_blink_planner and isinstance(self, BatchTableEnvironment): | |||
| if self._is_blink_planner and isinstance(self, BatchTableEnvironment) \ | |||
| or self._unified: | |||
|
@HuangXingBo Thanks for your review. I have updated this PR. |
WeiZhong94
force-pushed
the
FLINK-20994
branch
from
73dc09e
to
c254141
Compare
|
@flinkbot run azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request adds public method to create TableEnvironment in PyFlink.
Brief change log
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes)Documentation