Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flink 20348 kafka avro connector examples #14763

Closed

Conversation

sv3ndk
Copy link
Contributor

@sv3ndk sv3ndk commented Jan 26, 2021

What is the purpose of the change

  • Provide additional examples of how to use the avro-confluent format. In particular, no example of how to serialize the kafka key or use the upsert connector are currently mentioned in the avro confluent connector documentation

Brief change log

  • Added an example of a table serializing the kafka value in an avro record registered in the schema registry, while keeping the key in raw format
  • Added an example of how to write to that table
  • Added an example of a table using the schema registry for both the key and value
  • Added an example of using the schema registry together with the kafka upsert connector

Only the English version of the documentation has been updated so far. Once the examples are approved, I'm happy to copy/paste them to the Chinese version of the documentation, at which point I'll need support for the few sentences that were updated/added.

Verifying this change

Manually executed ./build_docs.sh -p to check visually the result

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 26, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit afadbd4 (Fri May 28 08:06:58 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • Invalid pull request title: No valid Jira ID provided

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@sv3ndk
Copy link
Contributor Author

sv3ndk commented Jan 26, 2021

I'm realizing I used the wrong ticket number => closing and will re-open correctly

@sv3ndk sv3ndk closed this Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants