Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-3195] [examples] Consolidate Java/Scala and batch/streaming examples #1482

Closed
wants to merge 1 commit into from

Conversation

StephanEwen
Copy link
Contributor

This pull request consolidates the examples:

  • One root project flink-examples
  • Subprojects flink-examples-batch and flink-examples-streaming
  • Batch examples are put into the distribution under examples/batch
  • Streaming examples are now also put into the distribution under examples/streaming
  • Java / Scala examples are always in one project. Since Java code never references Scala code, this should be okay, even for Eclipse
  • Removed redundant jars, such as WordCoundPOJO, and EnumTrianglesOpt. Since the JARs do not add any visible difference, they are not necessary and only confusing.
  • Rename PageRankBasic to PageRank

Open question: Moving the final example jars to examples/batch breaks a few web tutorials. Since these tutorials usually mention a Flink version (and this is simple to figure out for users), I think it is okay.

An alternative is to have all examples in the /examples folder and changing the names to make them unique, for example WordCount.jar and StreamingWordCount.jar.

…unify batch and streaming examples under on parent project
import org.apache.flink.examples.java.graph.util.EnumTrianglesData;
import org.apache.flink.examples.java.graph.util.EnumTrianglesDataTypes.Edge;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edge, EdgeWithDegrees, and Triad should be added back to the imports to make the code more readable.

@fhueske
Copy link
Contributor

fhueske commented Jan 5, 2016

I like the restructuring. I am also fine with remove redundant examples. However, I think we should either not rename the triangle enumeration jar to EnumerateGraphTriangles.jar or also rename the source file. Otherwise it is not clear which code is contained in the jar. I would also be OK with removing the EnumTriangleOpt example completely.

I think it is OK to move the batch example to a subfolder. They should be rather easy to find.

@rmetzger
Copy link
Contributor

rmetzger commented Jan 6, 2016

I'd like to finish the project restructure and I'll use this PR as a base. I'll also address Fabian's comments.

rmetzger added a commit to rmetzger/flink that referenced this pull request Jan 14, 2016
rmetzger added a commit to rmetzger/flink that referenced this pull request Jan 14, 2016
@asfgit asfgit closed this in e9bf13d Jan 14, 2016
hequn8128 pushed a commit to hequn8128/flink that referenced this pull request Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants