-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(1.12) [FLINK-21132][runtime] Don't end input on stop with savepoint #14829
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 1a79b32 (Fri May 28 08:16:50 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
bd5678e
to
7f5fc2b
Compare
EndOfInput was used to handle any stopping of the job. When stopping with savepoint the input is not actually ended. This causes issues with some sinks (e.g. Iceberg). With this change, endInput is not call for stop-with-savepoint. To differentiate stop-with-savepoint from other cases only checkpoint (RPC/barriers) are considered and not network EOP. That's enough because EOP is only injected after the CP completion (i.e. when the downstream is also notified by sync savepoint by CP barriers).
…h chaining strategy
6bce0c0
to
573520d
Compare
ABP failure is not related (FLINK-21025). |
573520d
to
a06f09b
Compare
a06f09b
to
1a79b32
Compare
AZP build failure is not related to this PR changes (FLINK-21051). |
What is the purpose of the change
(1.12 backport)
Verifying this change
SavepointITCase
(testStopSavepointWithBoundedInput
,testStopSavepointWithBoundedInputConcurrently
)StreamTaskTest
(testSyncSavepointAborted
,testSyncSavepointAbortedAsync
,testSyncSavepointCompleted
)Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: yes (endInput
is not called anymore for stop-with-savepoint)Documentation