Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-21238][python] Support to close PythonFunctionFactory #14842

Closed
wants to merge 3 commits into from
Closed

[FLINK-21238][python] Support to close PythonFunctionFactory #14842

wants to merge 3 commits into from

Conversation

dianfu
Copy link
Contributor

@dianfu dianfu commented Feb 3, 2021

What is the purpose of the change

This pull request support to close PythonFunctionFactory manually.

Brief change log

  • Introduce PythonFunctionFactoryImpl which allows to close PythonFunctionFactory
  • Introduce PYTHON_FUNCTION_FACTORY_CACHE which is responsible for closing inactive PythonFunctionFactory periodically.

Verifying this change

This change can be verified by the existing test cases.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@dianfu dianfu changed the title [FLINK-21238][python] Support to close PythonFunctionFactory manually [FLINK-21238][python] Support to close PythonFunctionFactory Feb 3, 2021
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 3, 2021 •
edited

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit fc435fd (Fri May 28 08:57:39 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 3, 2021 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

WeiZhong94
WeiZhong94 reviewed Feb 4, 2021
View reviewed changes
Copy link
Contributor

@WeiZhong94 WeiZhong94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dianfu Thanks for your PR! I have left some comments for you.

flink-python/src/main/java/org/apache/flink/client/python/PythonFunctionFactoryImpl.java Outdated
public void close() {
if (shutdownHook != null) {
if (Runtime.getRuntime().removeShutdownHook(shutdownHook)) {
shutdownHook.start();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can call shutdownHook.run() directly so that the exceptions can be captured in current call stack.

flink-python/src/test/java/org/apache/flink/client/python/PythonFunctionFactoryTest.java Outdated
@@ -56,6 +65,38 @@ public static void main(String[] args) throws Exception {
cleanEnvironment();
}

@Test
public void testCache() throws ExecutionException {
LoadingCache<String, String> cache =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use CacheKey as the key of this test case?

...-common/src/main/java/org/apache/flink/table/functions/python/utils/PythonFunctionUtils.java Outdated
@@ -39,15 +37,16 @@ public static PythonFunction getPythonFunction(
Thread.currentThread().getContextClassLoader());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use the class loader in the parameter

flink-python/src/main/java/org/apache/flink/client/python/PythonFunctionFactory.java
}
}

class CacheKey {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need add java doc here.

@WeiZhong94 WeiZhong94 closed this in 08bb6c1 Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiZhong94 WeiZhong94 WeiZhong94 left review comments

Assignees
No one assigned
Labels
component=API/Python review=description?
Projects
None yet
Milestone
No milestone
4 participants
@dianfu @flinkbot @WeiZhong94 @rmetzger