Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-20957][task][tests] Make sure we enter the measured sleep after the Task thread started measuring backPressure/idle time #14898

Merged
merged 1 commit into from Feb 9, 2021

Conversation

pnowojski
Copy link
Contributor

@pnowojski pnowojski commented Feb 8, 2021

Make sure that the Task thread actually starts measuring the backpressure before
we start the measured sleep. The WaitingThread is started from within the mailbox
so we should first wait until mailbox loop starts idling before we enter the
measured sleep

Verifying this change

Bug was easy to reproduce/verify after modifying WaitingThread starting sequence from:

            executor.submit(
                    waitingThread::start,
                    "This task will submit another task to execute after processing input once.");

to:

            executor.submit(() -> {
                            waitingThread.start();
                            Thread.sleep(10);
                     },
                    "This task will submit another task to execute after processing input once.");

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 8, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a1b6ebd (Mon Feb 08 10:48:06 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

…r the Task thread started measuring backPressure/idle time

Make sure that the Task thread actually starts measuring the backpressure before
we start the measured sleep. The WaitingThread is started from within the mailbox
so we should first wait until mailbox loop starts idling before we enter the
measured sleep

Bug was easy to reproduce/verify after modifying `WaitingThread` starting sequence from:
```
executor.submit(
  waitingThread::start,
  "This task will submit another task to execute after processing input once.");
```
to:
```
executor.submit(() -> {
    waitingThread.start();
    Thread.sleep(10);
  },
  "This task will submit another task to execute after processing input once.");
```
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 8, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@rkhachatryan rkhachatryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pnowojski pnowojski merged commit 10f4ed0 into apache:master Feb 9, 2021
@pnowojski pnowojski deleted the f20957 branch February 9, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants