Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-21369][docs] Document Checkpoint Storage #14932

Closed
wants to merge 3 commits into from

Conversation

sjwiesman
Copy link
Contributor

@sjwiesman sjwiesman commented Feb 12, 2021

What is the purpose of the change

Add documentation for the new Checkpoint Storage abstraction and new State Backend apis (HashMap and EmbeddedRocksDB).

I also cleaned up a few broken links and other misc I found along the way

@sjwiesman
Copy link
Contributor Author

cc @rkhachatryan & @alpinegizmo

@sjwiesman sjwiesman changed the title Checkpoint storage docs [FLINK-21369][docs] Document Checkpoint Storage Feb 12, 2021
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 95e05ce (Fri Feb 12 19:46:25 UTC 2021)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 12, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@alpinegizmo alpinegizmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks good, but I found a bunch of nits and had a question or two whether something is correct.

docs/content/docs/ops/state/checkpoints.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/checkpoints.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/checkpoints.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/checkpoints.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/savepoints.md Outdated Show resolved Hide resolved
@sjwiesman sjwiesman force-pushed the checkpoint-storage-docs branch 2 times, most recently from 4b952f2 to d42451f Compare February 25, 2021 19:16
@sjwiesman
Copy link
Contributor Author

@alpinegizmo thank you for the review, I hope I've addressed all your comments.

Sorry for force pushing, I messed up a rebase.

@sjwiesman sjwiesman closed this in b4dc5eb Mar 1, 2021
@sjwiesman
Copy link
Contributor Author

mergind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants