FLINK-3197: InputStream not closed in BinaryInputFormat#createStatistics #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InputStream not closed in BinaryInputFormat#createStatistics
| blockInfo.read(new DataInputViewStreamWrapper(fdis)); | ||
| totalCount += blockInfo.getAccumulatedRecordCount(); | ||
| fdis.close(); |
There was a problem hiding this comment.
Generally it is expected to enclose these type of IO streams/files to be enclosed in a try/finally block.
There was a problem hiding this comment.
Agreed, we should try and consistently use a "try-with-resource" clause for streams.
There was a problem hiding this comment.
+1, or to use the try with resources construct.
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Jan 14, 2016
…istics reliably This closes apache#1494
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Jan 14, 2016
…istics reliably This closes apache#1494
ChengXiangLi
pushed a commit
to ChengXiangLi/flink
that referenced
this pull request
Jan 25, 2016
…istics reliably This closes apache#1494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.