New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-14869][core] Discard zero-valued extended resources in ResourceSpec/ResourceProfile #14955
[FLINK-14869][core] Discard zero-valued extended resources in ResourceSpec/ResourceProfile #14955
Conversation
cc @zhuzhurk |
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit d30e586 (Thu Feb 18 06:20:04 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. LGTM except for some minor comments.
flink-core/src/test/java/org/apache/flink/api/common/resources/ResourceTest.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
Outdated
Show resolved
Hide resolved
...k-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
Outdated
Show resolved
Hide resolved
...k-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
Outdated
Show resolved
Hide resolved
Thanks for the review, @KarmaGYZ. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR @xintongsong
The change generally looks good to me. I have a few minor comments.
...k-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
Show resolved
Hide resolved
...k-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
Outdated
Show resolved
Hide resolved
...ntime/src/test/java/org/apache/flink/runtime/clusterframework/types/ResourceProfileTest.java
Outdated
Show resolved
Hide resolved
216d83a
to
e3b8d2e
Compare
Thanks for the review, @zhuzhurk. Comments addressed. |
…ces in ResourceSpec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments. @xintongsong
LGTM.
No description provided.