[FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler #14970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tPoolService and Scheduler factories The SlotPoolServiceSchedulerFactory bundles the SlotPoolServiceFactory and SchedulerNGFactory to make sure that we only instantiate valid SlotPoolService and SchedulerNG combinations.
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit c12ff62 (Fri Feb 19 17:34:46 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
…dle SlotPoolService and Scheduler factories
Note that this commit also changes the system property to enable the adaptive scheduler from flink.tests.enable-declarative-scheduler to flink.tests.enable-adaptive-scheduler.
tillrohrmann
force-pushed
the
FLINK-21390
branch
from
c12ff62
to
08cce5c
Compare
zentol
approved these changes
Feb 21, 2021
|
Thanks for the review @zentol. Merging this PR now. |
|
Why were the configuration keys not renamed in this PR? |
|
I forgot to rename them. I will update them in a hotfix commit. |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the
DeclarativeSchedulerintoAdaptiveScheduler.Note that this commit also changes the system property to enable the adaptive scheduler
from
flink.tests.enable-declarative-schedulertoflink.tests.enable-adaptive-scheduler.This PR is based on #14969.