New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-21433][runtime] Always calculate defaultSlotResourceProfile from totalResourceProfile / numSlotsPerWorker. #14983
Conversation
cc @KarmaGYZ |
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 0b2aff6 (Mon Feb 22 11:49:06 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @xintongsong . It already looks good to me. I left a minor comment.
nit: there is a typo in the commit message of the 0b2aff6. Should be totalResourceProfile == defaultSlotResourceProfile.multiply(numSlots)
...ime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerUtils.java
Show resolved
Hide resolved
…TaskManagerIsNotReleasedInCaseOfConcurrentAllocation
…reating PendingTaskManager. This is to make sure `totalSlotResourceProfile == defaultResourceProfile.multiply(numSlots)`.
…s for creating PendingTaskManager.
0b2aff6
to
c55b5ba
Compare
@KarmaGYZ |
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation