New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-21177][runtime] Support limiting max resources with FineGrainedSlotManager #15145
Conversation
cc @KarmaGYZ |
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 5188e3b (Thu Mar 11 06:29:41 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@@ -80,4 +84,10 @@ public ResourceProfile getFreeResourceOf(InstanceID instanceId) { | |||
.map(TaskManagerInfo::getAvailableResource) | |||
.orElse(ResourceProfile.ZERO); | |||
} | |||
|
|||
public ResourceProfile getPendingResource() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The total pending/registered resource will be calculated each time a task manager registered and a pending task manager added. I think it would be good to cache the result in TaskManagerTracker
.
Should not count non-empty slots for number of matched pending slots.
…e ClusterResourceStatisticsProvider The class references internal states of TaskManagerTracker, providing up-to-date statistics rather than snapshots.
…kManagerTracker. This is to avoid duplicated calculations. It will be frequently used for max resource limitation checks.
…grained resource management.
5188e3b
to
1b6f349
Compare
Thanks for the review, @KarmaGYZ. |
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation