New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-21581][core] Remove @PublicEvolving from RuntimeContext.getJobID #15352
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 8fa482c (Wed Mar 24 04:41:20 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change is fine but indentation is different
Thanks for reviewing! |
Why not squash the fixup commit before merging it? |
Just a stupid mistake:man_shrugging: |
What is the purpose of the change
Remove @PublicEvolving from RuntimeContext.getJobID
to make the API more consistent.
The method is added to japicmp ignore list.
Verifying this change
This change is a trivial rework without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: yesDocumentation