[FLINK-22050][network] Recycle all buffers before failing releaseAllBuffers

[rkhachatryan]

What is the purpose of the change

Currently, BufferManager.releaseAllBuffers fails as soon as the recycling of the first buffer fails.
This is correct as it likely caused by programmer error.

However, this might cause resource leak and lead to subsequent test failures.

With this PR, it first tries to recycle all buffers and then throws exception if any.

(this is an independent improvement; not solving the original problem)

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? no

[AHeise]

Thank you for this fix. I think we should always try to do best effort resource freeing even with intermittent errors.
Since, we are not super performance-critical here, I'd suggest to use Guava's Closer instead since that handles suppression transparently.

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8641227 (Sat Aug 28 11:11:42 UTC 2021)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[rkhachatryan]

Thanks for quick review.
Good point about Closer, I'll use it.

[flinkbot]

CI report:

• 2f7c0b2 Azure: CANCELED
• 219336a UNKNOWN
• 8641227 Azure: PENDING

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[dawidwys]

I am always sceptical about using third party libraries, especially shaded ones if we have our own alternatives. Could we use CloseableRegistry instead of Closer?

[rkhachatryan]

One reason why CloseableRegistry isn't suitable is that it uses closeAllQuietly, i.e. error is not propagated.
IIRC, the consensus was that it's fine to use Closer.

[pnowojski]

In the PR description it’s missing if it’s fixing the problem from the Jira ticket or not.

secondly please copy paste this description to the commit message as well.

[rkhachatryan]

In the PR description it’s missing if it’s fixing the problem from the Jira ticket or not.
secondly please copy paste this description to the commit message as well.

Done

[rkhachatryan]

I had to revert back to try blocks (instead of Closer) as LIFO order is apparently important here.

[AHeise]

LGTM. Let's merge it when AZP agrees.

[rkhachatryan]

Thanks for reviewing!
Merged into master as dd1d18794ce99ed5adec79a6a22c0a818258e4b3.