Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-21954][tests] Harden JobMasterQueryableStateTest, JobMasterTest.testRestoringFromSavepoint and .testRequestNextInputSplitWithGlobalFailover #15465

Closed
wants to merge 2 commits into from

Conversation

tillrohrmann
Copy link
Contributor

This commit fixes the test instabilities JobMasterQueryableStateTest.*, JobMasterTest.testRestoringFromSavepoint and JobMasterTest.testRequestNextInputSplitWithGlobalFailover which were introduced because of FLINK-21602 which makes the ExecutionGraph creation asynchronous. Due to this change, we now have to wait until a task is submitted in order to ensure that the ExecutionGraph has been created.

…and .testRequestNextInputSplitWithGlobalFailover

The test instability has been introduced by FLINK-21602 because the ExecutionGraph
is now created asynchronously. This commit fixes the test instabilities in JobMasterTest
by waiting for a task submission before asserting on the state.
Due to FLINK-21602, the ExecutionGraph is now created asynchronously. That's why we
have to wait for a task submission until we can use queryable state because then the
ExecutionGraph is created.
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 1, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5f83d05 (Fri May 28 09:00:31 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 1, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@rmetzger rmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing the test instability!

@tillrohrmann
Copy link
Contributor Author

Thanks for the review @rmetzger and @zentol. Merging this PR now.

@tillrohrmann tillrohrmann deleted the FLINK-21954 branch April 8, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants