Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-21386][datastream] Postpone FromElementsFunction serialization to respect later type customization #15507

Closed
wants to merge 4 commits into from
Closed

[FLINK-21386][datastream] Postpone FromElementsFunction serialization to respect later type customization #15507

wants to merge 4 commits into from

Commits on Apr 7, 2021

  1. [FLINK-21386][datastream] Assert that AbstractUdfStreamOperator redir… 

    …ects OutputTypeConfigurable to function
    @kezhuw
    kezhuw committed Apr 7, 2021
    Copy the full SHA
    dc29a93 View commit details
    Browse the repository at this point in the history

  2. [FLINK-21386][datastream] Postpone FromElementsFunction serialization… 

    … to respect later type customization

This fixes cases where earlier determined serializer was incorrect and returns() was ignored.
    @kezhuw
    kezhuw committed Apr 7, 2021
    Copy the full SHA
    c12fdaf View commit details
    Browse the repository at this point in the history

  3. fixup! [FLINK-21386][datastream] Assert that AbstractUdfStreamOperato… 

    …r redirects OutputTypeConfigurable to function
    @kezhuw
    kezhuw committed Apr 7, 2021
    Copy the full SHA
    c5adc24 View commit details
    Browse the repository at this point in the history

  4. fixup! [FLINK-21386][datastream] Postpone FromElementsFunction serial… 

    …ization to respect later type customization

Changes after reviewing:
* Add `testFromElementsDeducedType` and `testFromElementsPostConstructionType` in `StreamExecutionEnvironmentTest`.
* More meaningful exception message for calling `setOutputType` after serialization/deserialization.
* Use `junit.rules.ExpectedException` instead of try-catch.
* Merge `testSetOutputTypeWithExistingBrokenSerializer` and `testSetOutputTypeWithDifferentSerializer` to one.
    @kezhuw
    kezhuw committed Apr 7, 2021
    Copy the full SHA
    493e760 View commit details
    Browse the repository at this point in the history