-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-22104][sql-client] Fix unstable SqlClientTest.testExecuteSqlFile #15534
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 556c5fe (Fri May 28 09:10:08 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
...k-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientInputOutputSwitch.java
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/SqlClientTest.java
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/SqlClientTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The build hangs on sql client tests. Please have a check. |
2253217
to
d929ba7
Compare
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
Show resolved
Hide resolved
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/TerminalUtils.java
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/SqlClient.java
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientTest.java
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/SqlClientTest.java
Show resolved
Hide resolved
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/SqlClientTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
The actual line is
LOAD MODULE Load a module. Syntax: 'LOAD MODULE <name> [WITH ('<key1>' =Q '<value1>' [, '<key2>' = '<value2>', ...])];'
But the expected line is
LOAD MODULE Load a module. Syntax: 'LOAD MODULE <name> [WITH ('<key1>' = '<value1>' [, '<key2>' = '<value2>', ...])];'
The main problem is the we hijack the System.in and the client echo the input to the output.
However, we don't need
QUIT
in this case. Therefore, we just usesetIn
where we needs.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation