Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-21032][table] Not use ParallelFiniteTestSource in CompactionITCaseBase #15538

Merged
merged 2 commits into from Apr 14, 2021

Conversation

JingsongLi
Copy link
Contributor

What is the purpose of the change

Fix tests unstable in CompactionITCaseBase.

Brief change log

ParallelFiniteTestSource leads to confusion of thread cooperation among multiple tasks, resulting in wrong results.
Use FiniteTestSource and rebalance instead of ParallelFiniteTestSource.

Verifying this change

CompactionITCaseBases

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)no
  • The serializers: (yes / no / don't know)no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)no
  • The S3 file system connector: (yes / no / don't know)no

Documentation

  • Does this pull request introduce a new feature? (yes / no)no

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 9, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit d5580c1 (Fri May 28 09:05:46 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 9, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@JingsongLi
Copy link
Contributor Author

I've debugged and verified that rebalance works.

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JingsongLi for the fix, The change looks well.
But I found the test innerTestNonPartition(3) in CompactionITCaseBase can not cover parallel compaction operators because the compaction-operator is following after compaction-coordinator whose parallelism is constant 1, and the env parallelism is not works, so I suggest to add 'sink.parallelism' = '3' option for FileCompactionITCaseBase and HiveSinkCompactionITCase

@JingsongLi
Copy link
Contributor Author

@leonardBang Nice catch! I have fixed source and compact operator.

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JingsongLi for the update, LGTM once the build passing

@JingsongLi JingsongLi merged commit cf2a4e4 into apache:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants