New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-21032][table] Not use ParallelFiniteTestSource in CompactionITCaseBase #15538
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit d5580c1 (Fri May 28 09:05:46 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
I've debugged and verified that rebalance works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JingsongLi for the fix, The change looks well.
But I found the test innerTestNonPartition(3)
in CompactionITCaseBase
can not cover parallel compaction operators because the compaction-operator
is following after compaction-coordinator
whose parallelism is constant 1, and the env parallelism is not works, so I suggest to add 'sink.parallelism' = '3'
option for FileCompactionITCaseBase
and HiveSinkCompactionITCase
@leonardBang Nice catch! I have fixed source and compact operator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JingsongLi for the update, LGTM once the build passing
What is the purpose of the change
Fix tests unstable in CompactionITCaseBase.
Brief change log
ParallelFiniteTestSource
leads to confusion of thread cooperation among multiple tasks, resulting in wrong results.Use
FiniteTestSource
and rebalance instead ofParallelFiniteTestSource
.Verifying this change
CompactionITCaseBase
sDoes this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)noDocumentation