[scala] Add ClosureCleaner for Scala Lambdas #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this stable enough to go into the 0.7 release? |
|
I don't see any tests in the pull request. |
|
Yes, It would be good to have those. But it is also good to know that all the existing Scala Tests still run. |
aljoscha
force-pushed
the
closure-cleaner
branch
from
99ad218
to
dbeface
Compare
|
I added some Test cases. |
aljoscha
force-pushed
the
closure-cleaner
branch
from
dbeface
to
1f18fc7
Compare
aljoscha
force-pushed
the
closure-cleaner
branch
2 times, most recently
from
2e0a003
to
a5cf6f5
Compare
|
Any comments, anyone want to do some further tests. Or should we merge this rather sooner than later. |
|
Looks good. Do the tests contain code from Apache Spark? If yes, I would add a note there as well... |
aljoscha
force-pushed
the
closure-cleaner
branch
from
a5cf6f5
to
f502b5b
Compare
|
Ok, I added a notice to the ITCase about the origin of the tests: Spark. |
|
Looks good to merge... |
|
Manually merged. |
zhijiangW
pushed a commit
to zhijiangW/flink
that referenced
this pull request
Jul 23, 2019
tzulitai
pushed a commit
to tzulitai/flink
that referenced
this pull request
Jan 15, 2021
jnh5y
pushed a commit
to jnh5y/flink
that referenced
this pull request
Dec 18, 2023
* [FRT-119] Removes sensitive log entries * Revert two files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.