Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22264][docs] Fix misleading statement about Flink Job Cluster Kubernetes Support in Flink Architecture page #15602

Conversation

FuyaoLi2017
Copy link
Contributor

@FuyaoLi2017 FuyaoLi2017 commented Apr 14, 2021

What is the purpose of the change

I noticed a conflict in the document statement for per-job mode support for Kubernetes.

In the doc here [1], it mentions

in a Flink Job Cluster, the available cluster manager (like YARN or Kubernetes) is used to spin up a cluster for each submitted job and this cluster is available to that job only.

It implies per job mode is supported in Kubernetes.

However, in the docs [2] and [3], it clearly points out per-job mode is not supported in Kubernetes.

To avoid the misunderstanding, I think we should fix the statement in the Flink Architecture page and add an extra hint note here. I had a discussion with @wangyang0918 in flink user mailing list earlier on this issue and he agrees to patch such a change.

[1] https://ci.apache.org/projects/flink/flink-docs-master/docs/concepts/flink-architecture/#flink-job-cluster

[2] https://ci.apache.org/projects/flink/flink-docs-master/docs/deployment/resource-providers/native_kubernetes/#per-job-cluster-mode

[3] https://ci.apache.org/projects/flink/flink-docs-master/docs/deployment/resource-providers/standalone/kubernetes/

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (docs)

…Kubernetes Support in Flink Architecture page
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 14, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a63a44d (Fri May 28 11:04:24 UTC 2021)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 14, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@wangyang0918 wangyang0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the documentation. LGTM. +1

@wangyang0918
Copy link
Contributor

cc @tillrohrmann Could you help with merging this PR?

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @FuyaoLi2017. LGTM. Merging it now.

tillrohrmann pushed a commit that referenced this pull request Apr 20, 2021
…Kubernetes Support in Flink Architecture page

[FLINK-22264][docs] Add Chinese documentation

This closes #15602.
@FuyaoLi2017 FuyaoLi2017 deleted the fix-kubernetes-per-job-support-statement branch April 23, 2021 23:03
@FuyaoLi2017 FuyaoLi2017 restored the fix-kubernetes-per-job-support-statement branch April 27, 2021 04:36
@FuyaoLi2017 FuyaoLi2017 deleted the fix-kubernetes-per-job-support-statement branch April 27, 2021 04:41
@FuyaoLi2017
Copy link
Contributor Author

@tillrohrmann Hello Till, just have one small question, why the committer username of this PR appears as fuyli instead of @FuyaoLi2017 ? fuyli is my alias for my company's laptop, hhh. A little bit confused here. Thanks.

@tillrohrmann
Copy link
Contributor

Probably because you haven't associated your Github account with your used email address fuyao.li@oracle.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants