-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-22264][docs] Fix misleading statement about Flink Job Cluster Kubernetes Support in Flink Architecture page #15602
Conversation
…Kubernetes Support in Flink Architecture page
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit a63a44d (Fri May 28 11:04:24 UTC 2021) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the documentation. LGTM. +1
cc @tillrohrmann Could you help with merging this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR @FuyaoLi2017. LGTM. Merging it now.
…Kubernetes Support in Flink Architecture page [FLINK-22264][docs] Add Chinese documentation This closes #15602.
@tillrohrmann Hello Till, just have one small question, why the committer username of this PR appears as fuyli instead of @FuyaoLi2017 ? fuyli is my alias for my company's laptop, hhh. A little bit confused here. Thanks. |
Probably because you haven't associated your Github account with your used email address |
What is the purpose of the change
I noticed a conflict in the document statement for per-job mode support for Kubernetes.
In the doc here [1], it mentions
in a Flink Job Cluster, the available cluster manager (like YARN or Kubernetes) is used to spin up a cluster for each submitted job and this cluster is available to that job only.
It implies per job mode is supported in Kubernetes.
However, in the docs [2] and [3], it clearly points out per-job mode is not supported in Kubernetes.
To avoid the misunderstanding, I think we should fix the statement in the Flink Architecture page and add an extra hint note here. I had a discussion with @wangyang0918 in flink user mailing list earlier on this issue and he agrees to patch such a change.
[1] https://ci.apache.org/projects/flink/flink-docs-master/docs/concepts/flink-architecture/#flink-job-cluster
[2] https://ci.apache.org/projects/flink/flink-docs-master/docs/deployment/resource-providers/native_kubernetes/#per-job-cluster-mode
[3] https://ci.apache.org/projects/flink/flink-docs-master/docs/deployment/resource-providers/standalone/kubernetes/
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation