Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22338][table-planner] Clear watermark output when test finished for FromElementSourceFunctionWithWatermark #15659

Merged
merged 1 commit into from Apr 19, 2021

Conversation

fsk119
Copy link
Member

@fsk119 fsk119 commented Apr 19, 2021

…d for FromElementSourceFunctionWithWatermark

What is the purpose of the change

Clear the watermark output per test. To reproduce this bug, please run SourceWatermarkITCase twice.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…d for FromElementSourceFunctionWithWatermark
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 19, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit ece93ac (Sat Aug 28 11:14:34 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 19, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fsk119 , Looks good to me.

@JingsongLi JingsongLi changed the title [FLINK-22338][blink planner] Clear watermark output when test finishe… [FLINK-22338][table-planner] Clear watermark output when test finished for FromElementSourceFunctionWithWatermark Apr 19, 2021
@JingsongLi JingsongLi merged commit 5fbf0d7 into apache:master Apr 19, 2021
@fsk119 fsk119 deleted the FLINK-22338 branch November 22, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants