Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22275][table] Support random past for timestamp types in datagen connector #15703

Merged
merged 2 commits into from Sep 14, 2021

Conversation

yittg
Copy link
Contributor

@yittg yittg commented Apr 21, 2021

What is the purpose of the change

Introduce a max-past duration option for timestamp type fields. If the max-past is specified, it will resolve a past timestamp relative to the current timestamp of the local machine.

You can use it to achieve the out-of-order effect.

Brief change log

  • Add a max-past option for timestamp types in datagen connector.

Verifying this change

This change added tests and can be verified as follows:

  • Added test that validates that the max-past option is available.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 21, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit c6072f7 (Fri May 28 11:09:24 UTC 2021)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❗ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 21, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@yittg
Copy link
Contributor Author

yittg commented Apr 22, 2021

@flinkbot attention @wuchong @lirui-apache

@yittg
Copy link
Contributor Author

yittg commented May 7, 2021

@wuchong PTAL.

@wuchong
Copy link
Member

wuchong commented May 28, 2021

cc @lirui-apache

@yittg
Copy link
Contributor Author

yittg commented Jun 8, 2021

@luoyuxia Thanks for your comments, fixed them.

@yittg
Copy link
Contributor Author

yittg commented Jun 21, 2021

@luoyuxia @wuchong Do you have some time to make this change continue?

Introduce a `max-past` duration option for timestamp type fields. If the
`max-past` is specified, it will resolve a past timestamp relative to
the current timestamp of the local machine.

You can use it to achieve the out-of-order effect.
@yittg
Copy link
Contributor Author

yittg commented Sep 14, 2021

Thanks @wuchong , i've pushed the fix. PTAL

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong
Copy link
Member

wuchong commented Sep 14, 2021

I will merge it once build is passed.

@wuchong wuchong merged commit f74db4b into apache:master Sep 14, 2021
@yittg yittg deleted the data-gen-past branch September 15, 2021 01:10
@yittg
Copy link
Contributor Author

yittg commented Sep 15, 2021

Thanks @wuchong

jianyun8023 pushed a commit to streamnative/flink that referenced this pull request Sep 22, 2021
niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants