[FLINK-22289] Update JDBC XA sink docs

[curcur]

No description provided.

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a493e7a (Fri May 28 11:05:03 UTC 2021)

Warnings:

• Documentation files were touched, but no docs/content.zh/ files: Update Chinese documentation or file Jira ticket.

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• a493e7a Azure: FAILURE

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[rkhachatryan]

Thanks for the PR @curcur.

Should we also remove this warning:

Attention: In 1.13, Flink JDBC sink does not support exactly-once mode with MySQL or other databases that do not support
multiple XA transaction per connection. We will improve the support in FLINK-22239.
?

[rkhachatryan]

Are you sure we can link to this page? (PostgreSQL has its own license)

[curcur]

It is using the same link as
https://ci.apache.org/projects/flink/flink-docs-master/docs/connectors/table/jdbc/

So I would only say this link does not include extra legal issue

[rkhachatryan]

I think users will likely need this too:

        pgxaDataSource.setUser(username);
        pgxaDataSource.setPassword(password);

[curcur]

Yes, usually it should.

My intention for this example is to make this example "runnable out of box"; That says if user copy-paste the example to its IDE, and has postgres installed with default set up, it would work.

I installed postgre and used its default table as an example. The default one can be accessed without username and password (with default username and password).

[curcur]

Thanks for the PR @curcur.

Should we also remove this warning:

Attention: In 1.13, Flink JDBC sink does not support exactly-once mode with MySQL or other databases that do not support
multiple XA transaction per connection. We will improve the support in FLINK-22239.
?

That's a good point.

[curcur]

Hey @rkhachatryan , thanks for reviewing. I've removed the limitation part. How do you think of the comments above? I do not have strong opinions either of them.

[rkhachatryan]

Thanks for updating the PR @curcur, I agree with your comments.

[rkhachatryan]

CI failure unrelated, passed in a private branch, merging.